Commit 03976af8 authored Oct 08, 2019 by Hou Tao Committed by Vignesh Raghavendra Nov 09, 2019

mtd: cfi_cmdset_0002: don't free cfi->cfiq in error path of cfi_amdstd_setup()



Else there may be a double-free problem, because cfi->cfiq will
be freed by mtd_do_chip_probe() if both the two invocations of
check_cmd_set() return failure.

Signed-off-by: Hou Tao <houtao1@huawei.com>
Reviewed-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>

parent ea4f5135

drivers/mtd/chips/cfi_cmdset_0002.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -785,7 +785,6 @@ static struct mtd_info cfi_amdstd_setup(struct mtd_info mtd)
		kfree(mtd->eraseregions);
		kfree(mtd);
		kfree(cfi->cmdset_priv);
		kfree(cfi->cfiq);
		return NULL;
		}

Admin message