Commit 036f463f authored Jul 05, 2019 by Darrick J. Wong

xfs: online scrub needn't bother zeroing its temporary buffer



The xattr scrubber functions use the temporary memory buffer either for
storing bitmaps or for testing if attribute value extraction works.  The
bitmap code always zeroes what it needs and the value extraction sets
the buffer contents, so it's not necessary to waste CPU time zeroing on
allocation.

Note that while we never read the contents that the attr value
extraction function sets, we do need to call it to check the remote
attribute header and CRCs to check for corruption.

A flame graph analysis showed that we were spending 7% of a xfs_scrub
run (the whole program, not just the attr scrubber itself) allocating
and zeroing 64k segments needlessly.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>

parent 6d6ccedd

fs/xfs/scrub/attr.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -53,7 +53,11 @@ xchk_setup_xattr_buf(
		sc->buf = NULL;
		}

		ab = kmem_zalloc_large(sizeof(*ab) + sz, flags);
		/*
		* Don't zero the buffer upon allocation to avoid runtime overhead.
		* All users must be careful never to read uninitialized contents.
		*/
		ab = kmem_alloc_large(sizeof(*ab) + sz, flags);
		if (!ab)
		return -ENOMEM;

Admin message