Commit 035fbafc authored Oct 12, 2020 by Colin Ian King Committed by Jens Axboe Oct 17, 2020

io_uring: Fix sizeof() mismatch



An incorrect sizeof() is being used, sizeof(file_data->table) is not
correct, it should be sizeof(*file_data->table).

Fixes: 5398ae69 ("io_uring: clean file_data access in files_register")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)")
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 071a0578

fs/io_uring.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -7306,7 +7306,7 @@ static int io_sqe_files_register(struct io_ring_ctx ctx, void __user arg,
		spin_lock_init(&file_data->lock);

		nr_tables = DIV_ROUND_UP(nr_args, IORING_MAX_FILES_TABLE);
		file_data->table = kcalloc(nr_tables, sizeof(file_data->table),
		file_data->table = kcalloc(nr_tables, sizeof(*file_data->table),
		GFP_KERNEL);
		if (!file_data->table)
		goto out_free;

Admin message