cgroup: replace error handling in cgroup_init() with WARN_ON()s (035f4f51) · Commits · 戴 / test

The init sequence shouldn't fail short of bugs and even when it does it's better to continue with the rest of initialization and we were silently ignoring /proc/cgroups creation failure. Drop the explicit error handling and wrap sysfs_create_mount_point(), register_filesystem() and proc_create() with WARN_ON()s. Signed-off-by:

Tejun Heo <tj@kernel.org> Acked-by:

Li Zefan <lizefan@huawei.com> Cc: Johannes Weiner <hannes@cmpxchg.org>

kernel/cgroup.c

+4 −11

Original line number	Diff line number	Diff line
		@@ -5242,7 +5242,7 @@ int __init cgroup_init(void)
		{
		struct cgroup_subsys *ss;
		unsigned long key;
		int ssid, err;
		int ssid;

		BUG_ON(percpu_init_rwsem(&cgroup_threadgroup_rwsem));
		BUG_ON(cgroup_init_cftypes(NULL, cgroup_dfl_base_files));
		@@ -5304,17 +5304,10 @@ int __init cgroup_init(void)
		ss->bind(init_css_set.subsys[ssid]);
		}

		err = sysfs_create_mount_point(fs_kobj, "cgroup");
		if (err)
		return err;

		err = register_filesystem(&cgroup_fs_type);
		if (err < 0) {
		sysfs_remove_mount_point(fs_kobj, "cgroup");
		return err;
		}
		WARN_ON(sysfs_create_mount_point(fs_kobj, "cgroup"));
		WARN_ON(register_filesystem(&cgroup_fs_type));
		WARN_ON(!proc_create("cgroups", 0, NULL, &proc_cgroupstats_operations));

		proc_create("cgroups", 0, NULL, &proc_cgroupstats_operations);
		return 0;
		}

Admin message