Commit 035bfd05 authored Jul 28, 2020 by Christoph Hellwig Committed by David S. Miller Jul 28, 2020

net: make sockptr_is_null strict aliasing safe



While the kernel in general is not strict aliasing safe we can trivially
do that in sockptr_is_null without affecting code generation, so always
check the actually assigned union member.

Reported-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a3ad434a

include/linux/sockptr.h

+3 −1

Original line number	Diff line number	Diff line
		@@ -64,7 +64,9 @@ static inline int __must_check init_user_sockptr(sockptr_t sp, void __user p)

		static inline bool sockptr_is_null(sockptr_t sockptr)
		{
		return !sockptr.user && !sockptr.kernel;
		if (sockptr_is_kernel(sockptr))
		return !sockptr.kernel;
		return !sockptr.user;
		}

		static inline int copy_from_sockptr(void *dst, sockptr_t src, size_t size)

Admin message