Commit 034d655e authored May 27, 2009 by Johannes Berg Committed by John W. Linville Jun 03, 2009

cfg80211: disallow interfering with stations on non-AP (part 2)



On non-AP interfaces userspace has no business interfering with
the station management, this can confuse mac80211 (and other
drivers probably wouldn't support it anyway). Allow adding and
removing stations only on AP interfaces.

(Reconcile this w/ previous version of patch posted with same
subject... -- JWL)

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 7ba10a8e

net/wireless/nl80211.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -1687,6 +1687,12 @@ static int nl80211_set_station(struct sk_buff skb, struct genl_info info)
		if (err)
		goto out_rtnl;

		if (dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP &&
		dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP_VLAN) {
		err = -EINVAL;
		goto out;
		}

		err = get_vlan(info->attrs[NL80211_ATTR_STA_VLAN], drv, &params.vlan);
		if (err)
		goto out;

Admin message