Commit 03374518 authored Nov 20, 2015 by Jesper Dangaard Brouer Committed by Linus Torvalds Nov 22, 2015

slub: add missing kmem cgroup support to kmem_cache_free_bulk



Initial implementation missed support for kmem cgroup support in
kmem_cache_free_bulk() call, add this.

If CONFIG_MEMCG_KMEM is not enabled, the compiler should be smart enough
to not add any asm code.

Incoming bulk free objects can belong to different kmem cgroups, and
object free call can happen at a later point outside memcg context.  Thus,
we need to keep the orig kmem_cache, to correctly verify if a memcg object
match against its "root_cache" (s->memcg_params.root_cache).

Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Reviewed-by: Vladimir Davydov <vdavydov@virtuozzo.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 03ec0ed5

mm/slub.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -2887,13 +2887,17 @@ static int build_detached_freelist(struct kmem_cache *s, size_t size,


		/* Note that interrupts must be enabled when calling this function. */
		void kmem_cache_free_bulk(struct kmem_cache s, size_t size, void *p)
		void kmem_cache_free_bulk(struct kmem_cache orig_s, size_t size, void *p)
		{
		if (WARN_ON(!size))
		return;

		do {
		struct detached_freelist df;
		struct kmem_cache *s;

		/* Support for memcg */
		s = cache_from_obj(orig_s, p[size - 1]);

		size = build_detached_freelist(s, size, p, &df);
		if (unlikely(!df.page))

Admin message