Commit 03358b0f authored May 26, 2020 by John Hubbard Committed by Greg Kroah-Hartman May 27, 2020

misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages()

This code was using get_user_pages*(), in approximately a "Case 1"
scenario (Direct IO), using the categorization from [1]. That means
that it's time to convert the get_user_pages*() + put_page() calls to
pin_user_pages*() + unpin_user_pages() calls.

There is some helpful background in [2]: basically, this is a small
part of fixing a long-standing disconnect between pinning pages, and
file systems' use of those pages.

[1] Documentation/core-api/pin_user_pages.rst

[2] "Explicit pinning of user-space pages":
    https://lwn.net/Articles/807108/



Cc: Derek Kiernan <derek.kiernan@xilinx.com>
Cc: Dragan Cvetic <dragan.cvetic@xilinx.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Link: https://lore.kernel.org/r/20200527012628.1100649-4-jhubbard@nvidia.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d25594d7

drivers/misc/xilinx_sdfec.c

+5 −6

Original line number	Diff line number	Diff line
		@@ -627,12 +627,11 @@ static int xsdfec_table_write(struct xsdfec_dev *xsdfec, u32 offset,

		nr_pages = n;

		res = get_user_pages_fast((unsigned long)src_ptr, nr_pages, 0, pages);
		res = pin_user_pages_fast((unsigned long)src_ptr, nr_pages, 0, pages);
		if (res < nr_pages) {
		if (res > 0) {
		for (i = 0; i < res; i++)
		put_page(pages[i]);
		}
		if (res > 0)
		unpin_user_pages(pages, res);

		return -EINVAL;
		}

		@@ -646,7 +645,7 @@ static int xsdfec_table_write(struct xsdfec_dev *xsdfec, u32 offset,
		reg++;
		} while ((reg < len) &&
		((reg * XSDFEC_REG_WIDTH_JUMP) % PAGE_SIZE));
		put_page(pages[i]);
		unpin_user_page(pages[i]);
		}
		return 0;
		}

Admin message