Commit 0331402a authored Jun 14, 2017 by Dan Carpenter Committed by David S. Miller Jun 14, 2017

qed: Fix an off by one bug



The p_l2_info->pp_qid_usage[] array has "p_l2_info->queues" elements so
the > here should be a >= or we write beyond the end of the array.

Fixes: bbe3f233 ("qed: Assign a unique per-queue index to queue-cid")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 44e179da

drivers/net/ethernet/qlogic/qed/qed_l2.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -161,7 +161,7 @@ static bool qed_eth_queue_qid_usage_add(struct qed_hwfn *p_hwfn,

		mutex_lock(&p_l2_info->lock);

		if (queue_id > p_l2_info->queues) {
		if (queue_id >= p_l2_info->queues) {
		DP_NOTICE(p_hwfn,
		"Requested to increase usage for qzone %04x out of %08x\n",
		queue_id, p_l2_info->queues);

Admin message