Commit 032a9966 authored Jun 23, 2020 by Max Gurtovoy Committed by Christoph Hellwig Jun 24, 2020

nvme-rdma: assign completion vector correctly



The completion vector index that is given during CQ creation can't
exceed the number of support vectors by the underlying RDMA device. This
violation currently can accure, for example, in case one will try to
connect with N regular read/write queues and M poll queues and the sum
of N + M > num_supported_vectors. This will lead to failure in establish
a connection to remote target. Instead, in that case, share a completion
vector between queues.

Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent 1b4ad7a5

drivers/nvme/host/rdma.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -470,7 +470,7 @@ static int nvme_rdma_create_queue_ib(struct nvme_rdma_queue *queue)
		* Spread I/O queues completion vectors according their queue index.
		* Admin queues can always go on completion vector 0.
		*/
		comp_vector = idx == 0 ? idx : idx - 1;
		comp_vector = (idx == 0 ? idx : idx - 1) % ibdev->num_comp_vectors;

		/* Polling queues need direct cq polling context */
		if (nvme_rdma_poll_queue(queue))

Admin message