Commit 03254e65 authored Oct 09, 2008 by Trond Myklebust

NFS: Fix attribute updates

This fixes a regression seen when running the Connectathon testsuite
against an ext3 filesystem. The reason was that the inode was constantly
being marked as 'just updated' by the jiffy wraparound test.
This again meant that newer GETATTR calls were failing to pass the
nfs_inode_attrs_need_update() test unless the changes caused a ctime update
on the server, since they were perceived as having been started before the
latest inode update.

Given that nfs_inode_attrs_need_update() already checks for wraparound
of nfsi->last_updated, we can drop the buggy "protection" in
nfs_update_inode().

Also make a slight micro-optimisation of nfs_inode_attrs_need_update(): we
are more often going to see time_after(fattr->time_start, nfsi->last_updated)
be true, rather than seeing an update of ctime/size, so put that test
first to ensure that we optimise away the ctime/size tests.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent 19d771f3

fs/nfs/inode.c

+4 −9

Original line number	Diff line number	Diff line
		@@ -933,9 +933,9 @@ static int nfs_inode_attrs_need_update(const struct inode *inode, const struct n
		{
		const struct nfs_inode *nfsi = NFS_I(inode);

		return nfs_ctime_need_update(inode, fattr) \|\|
		return time_after(fattr->time_start, nfsi->last_updated) \|\|
		nfs_ctime_need_update(inode, fattr) \|\|
		nfs_size_need_update(inode, fattr) \|\|
		time_after(fattr->time_start, nfsi->last_updated) \|\|
		time_after(nfsi->last_updated, jiffies);
		}

		@@ -1167,11 +1167,6 @@ static int nfs_update_inode(struct inode inode, struct nfs_fattr fattr)
		nfsi->attrtimeo = NFS_MAXATTRTIMEO(inode);
		nfsi->attrtimeo_timestamp = now;
		}
		/*
		* Avoid jiffy wraparound issues with nfsi->last_updated
		*/
		if (!time_in_range(nfsi->last_updated, nfsi->read_cache_jiffies, now))
		nfsi->last_updated = nfsi->read_cache_jiffies;
		}
		invalid &= ~NFS_INO_INVALID_ATTR;
		/* Don't invalidate the data if we were to blame */

Admin message