Commit 0324e75d authored by Stefan Wahren's avatar Stefan Wahren Committed by David S. Miller
Browse files

net: qualcomm: use net_device_ops instead of direct call 



There is no need to export qcaspi_netdev_open and qcaspi_netdev_close
because they are also accessible via the net_device_ops.

Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 00bc2e49

drivers/net/ethernet/qualcomm/qca_debug.c

+3 −2
Original line number Diff line number Diff line
@@ -275,6 +275,7 @@ qcaspi_get_ringparam(struct net_device *dev, struct ethtool_ringparam *ring) 
static int

qcaspi_set_ringparam(struct net_device *dev, struct ethtool_ringparam *ring)

{

	const struct net_device_ops *ops = dev->netdev_ops;

	struct qcaspi *qca = netdev_priv(dev);



	if ((ring->rx_pending) ||
@@ -283,13 +284,13 @@ qcaspi_set_ringparam(struct net_device *dev, struct ethtool_ringparam *ring) 
		return -EINVAL;



	if (netif_running(dev))

		qcaspi_netdev_close(dev);

		ops->ndo_stop(dev);



	qca->txr.count = max_t(u32, ring->tx_pending, TX_RING_MIN_LEN);

	qca->txr.count = min_t(u16, qca->txr.count, TX_RING_MAX_LEN);



	if (netif_running(dev))

		qcaspi_netdev_open(dev);

		ops->ndo_open(dev);



	return 0;

}

drivers/net/ethernet/qualcomm/qca_spi.c

+2 −2
Original line number Diff line number Diff line
@@ -603,7 +603,7 @@ qcaspi_intr_handler(int irq, void *data) 
	return IRQ_HANDLED;

}



int

static int

qcaspi_netdev_open(struct net_device *dev)

{

	struct qcaspi *qca = netdev_priv(dev);
@@ -640,7 +640,7 @@ qcaspi_netdev_open(struct net_device *dev) 
	return 0;

}



int

static int

qcaspi_netdev_close(struct net_device *dev)

{

	struct qcaspi *qca = netdev_priv(dev);

drivers/net/ethernet/qualcomm/qca_spi.h

+0 −3
Original line number Diff line number Diff line
@@ -108,7 +108,4 @@ struct qcaspi { 
	u16 burst_len;

};



int qcaspi_netdev_open(struct net_device *dev);

int qcaspi_netdev_close(struct net_device *dev);



#endif /* _QCA_SPI_H */

CRA Git | Maintained and supported by SUSTech CRA and CCSE