Commit 031ace8d authored by Simon Wunderlich's avatar Simon Wunderlich Committed by Antonio Quartulli
Browse files

batman-adv: add build checks for packet sizes 



With unrolling the batadv_header into the respective structures, the
offsetof checks are now useless. Instead, add build checks for all
packet types which go over the wire to avoid problems with wrong sizes
or compatibility issues on some architectures which don't use every day.

Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: default avatarAntonio Quartulli <antonio@meshcoding.com>
parent c28c0b6b

net/batman-adv/main.c

+17 −7
Original line number Diff line number Diff line
@@ -419,13 +419,23 @@ static void batadv_recv_handler_init(void) 
	for (i = BATADV_UNICAST_MIN; i <= BATADV_UNICAST_MAX; i++)

		batadv_rx_handler[i] = batadv_recv_unhandled_unicast_packet;



	/* compile time checks for struct member offsets */

	BUILD_BUG_ON(offsetof(struct batadv_unicast_4addr_packet, src) != 10);

	BUILD_BUG_ON(offsetof(struct batadv_unicast_packet, dest) != 4);

	BUILD_BUG_ON(offsetof(struct batadv_unicast_tvlv_packet, dst) != 4);

	BUILD_BUG_ON(offsetof(struct batadv_frag_packet, dest) != 4);

	BUILD_BUG_ON(offsetof(struct batadv_icmp_packet, dst) != 4);

	BUILD_BUG_ON(offsetof(struct batadv_icmp_packet_rr, dst) != 4);

	/* compile time checks for sizes */

	BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);

	BUILD_BUG_ON(sizeof(struct batadv_ogm_packet) != 24);

	BUILD_BUG_ON(sizeof(struct batadv_icmp_header) != 20);

	BUILD_BUG_ON(sizeof(struct batadv_icmp_packet) != 20);

	BUILD_BUG_ON(sizeof(struct batadv_icmp_packet_rr) != 116);

	BUILD_BUG_ON(sizeof(struct batadv_unicast_packet) != 10);

	BUILD_BUG_ON(sizeof(struct batadv_unicast_4addr_packet) != 18);

	BUILD_BUG_ON(sizeof(struct batadv_frag_packet) != 20);

	BUILD_BUG_ON(sizeof(struct batadv_bcast_packet) != 14);

	BUILD_BUG_ON(sizeof(struct batadv_coded_packet) != 46);

	BUILD_BUG_ON(sizeof(struct batadv_unicast_tvlv_packet) != 20);

	BUILD_BUG_ON(sizeof(struct batadv_tvlv_hdr) != 4);

	BUILD_BUG_ON(sizeof(struct batadv_tvlv_gateway_data) != 8);

	BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_vlan_data) != 8);

	BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_change) != 12);

	BUILD_BUG_ON(sizeof(struct batadv_tvlv_roam_adv) != 8);



	/* broadcast packet */

	batadv_rx_handler[BATADV_BCAST] = batadv_recv_bcast_packet;

CRA Git | Maintained and supported by SUSTech CRA and CCSE