Commit 03194379 authored by Allan Stephens's avatar Allan Stephens Committed by David S. Miller
Browse files

tipc: Fix initialization sequence problems when entering network mode 



This patch ensures that TIPC's topology service and configuration
service are shut down before switching into "network mode".  This
ensures that TIPC does not mistakenly try to send unnecessary
"publication withdraw" messages to other nodes before it is fully
initialized for sending off-node messages.  Note that the node's
current network address is now updated only after the two services
are shut down; this ensures that any existing connections to the
topology server are terminated correctly using the old address.

Signed-off-by: default avatarAllan Stephens <allan.stephens@windriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6d4a6672

net/tipc/config.c

+1 −2
Original line number Diff line number Diff line
@@ -293,7 +293,6 @@ static struct sk_buff *cfg_set_own_addr(void) 
	if (tipc_mode == TIPC_NET_MODE)

		return tipc_cfg_reply_error_string(TIPC_CFG_NOT_SUPPORTED

						   " (cannot change node address once assigned)");

	tipc_own_addr = addr;



	/*

	 * Must release all spinlocks before calling start_net() because
@@ -306,7 +305,7 @@ static struct sk_buff *cfg_set_own_addr(void) 
	 */



	spin_unlock_bh(&config_lock);

	tipc_core_start_net();

	tipc_core_start_net(addr);

	spin_lock_bh(&config_lock);

	return tipc_cfg_reply_none();

}

net/tipc/core.c

+2 −2
Original line number Diff line number Diff line
@@ -117,11 +117,11 @@ void tipc_core_stop_net(void) 
 * start_net - start TIPC networking sub-systems

 */



int tipc_core_start_net(void)

int tipc_core_start_net(unsigned long addr)

{

	int res;



	if ((res = tipc_net_start()) ||

	if ((res = tipc_net_start(addr)) ||

	    (res = tipc_eth_media_start())) {

		tipc_core_stop_net();

	}

net/tipc/core.h

+1 −1
Original line number Diff line number Diff line
@@ -202,7 +202,7 @@ extern atomic_t tipc_user_count; 


extern int  tipc_core_start(void);

extern void tipc_core_stop(void);

extern int  tipc_core_start_net(void);

extern int  tipc_core_start_net(unsigned long addr);

extern void tipc_core_stop_net(void);

extern int  tipc_handler_start(void);

extern void tipc_handler_stop(void);

net/tipc/net.c

+7 −3
Original line number Diff line number Diff line
@@ -266,7 +266,7 @@ void tipc_net_route_msg(struct sk_buff *buf) 
	tipc_link_send(buf, dnode, msg_link_selector(msg));

}



int tipc_net_start(void)

int tipc_net_start(u32 addr)

{

	char addr_string[16];

	int res;
@@ -274,6 +274,10 @@ int tipc_net_start(void) 
	if (tipc_mode != TIPC_NODE_MODE)

		return -ENOPROTOOPT;



	tipc_subscr_stop();

	tipc_cfg_stop();



	tipc_own_addr = addr;

	tipc_mode = TIPC_NET_MODE;

	tipc_named_reinit();

	tipc_port_reinit();
@@ -284,10 +288,10 @@ int tipc_net_start(void) 
	    (res = tipc_bclink_init())) {

		return res;

	}

	tipc_subscr_stop();

	tipc_cfg_stop();



	tipc_k_signal((Handler)tipc_subscr_start, 0);

	tipc_k_signal((Handler)tipc_cfg_init, 0);



	info("Started in network mode\n");

	info("Own node address %s, network identity %u\n",

	     addr_string_fill(addr_string, tipc_own_addr), tipc_net_id);

net/tipc/net.h

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ void tipc_net_route_msg(struct sk_buff *buf); 
struct node *tipc_net_select_remote_node(u32 addr, u32 ref);

u32 tipc_net_select_router(u32 addr, u32 ref);



int tipc_net_start(void);

int tipc_net_start(u32 addr);

void tipc_net_stop(void);



#endif

CRA Git | Maintained and supported by SUSTech CRA and CCSE