ARM: dts: NSP: Use hardware I2C for BCM958625HR (030cc6cb) · Commits · 戴 / test

Now that the i2c-bcm-iproc driver has been fixed to permit reading more than 63 bytes in a single transaction with commit ("i2c: iproc: Fix i2c master read more than 63 bytes") we no longer need to bitbang i2c over GPIOs which was necessary before to allow the PHYLINK/SFP subsystems to read SFP modules. Reviewed-by:

Ray Jui <ray.jui@broadcom.com> Signed-off-by:

Florian Fainelli <f.fainelli@gmail.com>

arch/arm/boot/dts/bcm958625hr.dts

+5 −10

Original line number	Diff line number	Diff line
		@@ -55,18 +55,9 @@
		priority = <200>;
		};

		/* Hardware I2C block cannot do more than 63 bytes per transfer,
		* which would prevent reading from a SFP's EEPROM (256 byte).
		*/
		i2c1: i2c {
		compatible = "i2c-gpio";
		sda-gpios = <&gpioa 5 (GPIO_ACTIVE_HIGH \| GPIO_OPEN_DRAIN)>;
		scl-gpios = <&gpioa 4 (GPIO_ACTIVE_HIGH \| GPIO_OPEN_DRAIN)>;
		};

		sfp: sfp {
		compatible = "sff,sfp";
		i2c-bus = <&i2c1>;
		i2c-bus = <&i2c0>;
		mod-def0-gpios = <&gpioa 28 GPIO_ACTIVE_LOW>;
		los-gpios = <&gpioa 24 GPIO_ACTIVE_HIGH>;
		tx-fault-gpios = <&gpioa 30 GPIO_ACTIVE_HIGH>;
		@@ -74,6 +65,10 @@
		};
		};

		&i2c0 {
		status = "okay";
		};

		&amac0 {
		status = "okay";
		};

Admin message