Commit 02f75405 authored May 27, 2013 by Dave Chinner Committed by Ben Myers May 30, 2013

xfs: disable swap extents ioctl on CRC enabled filesystems



Currently, swapping extents from one inode to another is a simple
act of switching data and attribute forks from one inode to another.
This, unfortunately in no longer so simple with CRC enabled
filesystems as there is owner information embedded into the BMBT
blocks that are swapped between inodes. Hence swapping the forks
between inodes results in the inodes having mapping blocks that
point to the wrong owner and hence are considered corrupt.

To fix this we need an extent tree block or record based swap
algorithm so that the BMBT block owner information can be updated
atomically in the swap transaction. This is a significant piece of
new work, so for the moment simply don't allow swap extent
operations to succeed on CRC enabled filesystems.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>

parent 709da6a6

fs/xfs/xfs_dfrag.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -219,6 +219,14 @@ xfs_swap_extents(
		int taforkblks = 0;
		__uint64_t tmp;

		/*
		* We have no way of updating owner information in the BMBT blocks for
		* each inode on CRC enabled filesystems, so to avoid corrupting the
		* this metadata we simply don't allow extent swaps to occur.
		*/
		if (xfs_sb_version_hascrc(&mp->m_sb))
		return XFS_ERROR(EINVAL);

		tempifp = kmem_alloc(sizeof(xfs_ifork_t), KM_MAYFAIL);
		if (!tempifp) {
		error = XFS_ERROR(ENOMEM);

Admin message