Commit 02cacede authored May 28, 2019 by Ivan Khoronzhuk Committed by David S. Miller May 29, 2019

net: ethernet: ti: cpsw: correct .ndo_open error path



It's found while review and probably never happens, but real number
of queues is set per device, and error path should be per device.
So split error path based on usage_count.

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6faaffb3

drivers/net/ethernet/ti/cpsw.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -1423,8 +1423,11 @@ static int cpsw_ndo_open(struct net_device *ndev)
		return 0;

		err_cleanup:
		if (!cpsw->usage_count) {
		cpdma_ctlr_stop(cpsw->dma);
		for_each_slave(priv, cpsw_slave_stop, cpsw);
		}

		pm_runtime_put_sync(cpsw->dev);
		netif_carrier_off(priv->ndev);
		return ret;

Admin message