cpuset: schedule hotplug propagation from cpuset_attach() if the cpuset is empty (02bb5863) · Commits · 戴 / test

cpuset is scheduled to be decoupled from cgroup_lock which will make hotplug handling race with task migration. cpus or mems will be allowed to go offline between ->can_attach() and ->attach(). If hotplug takes down all cpus or mems of a cpuset while attach is in progress, ->attach() may end up putting tasks into an empty cpuset. This patchset makes ->attach() schedule hotplug propagation if the cpuset is empty after attaching is complete. This will move the tasks to the nearest ancestor which can execute and the end result would be as if hotplug handling happened after the tasks finished attaching. cpuset_write_resmask() now also flushes cpuset_propagate_hotplug_wq to wait for propagations scheduled directly by cpuset_attach(). This currently doesn't make any functional difference as everything is protected by cgroup_mutex but enables decoupling the locking. Signed-off-by:

Tejun Heo <tj@kernel.org> Acked-by:

Li Zefan <lizefan@huawei.com>

kernel/cpuset.c

+14 −0

Original line number	Diff line number	Diff line
		@@ -266,6 +266,7 @@ static struct workqueue_struct *cpuset_propagate_hotplug_wq;

		static void cpuset_hotplug_workfn(struct work_struct *work);
		static void cpuset_propagate_hotplug_workfn(struct work_struct *work);
		static void schedule_cpuset_propagate_hotplug(struct cpuset *cs);

		static DECLARE_WORK(cpuset_hotplug_work, cpuset_hotplug_workfn);

		@@ -1464,6 +1465,14 @@ static void cpuset_attach(struct cgroup cgrp, struct cgroup_taskset tset)
		}

		cs->attach_in_progress--;

		/*
		* We may have raced with CPU/memory hotunplug. Trigger hotplug
		* propagation if @cs doesn't have any CPU or memory. It will move
		* the newly added tasks to the nearest parent which can execute.
		*/
		if (cpumask_empty(cs->cpus_allowed) \|\| nodes_empty(cs->mems_allowed))
		schedule_cpuset_propagate_hotplug(cs);
		}

		/* The various types of files and directories in a cpuset file system */
		@@ -1569,8 +1578,13 @@ static int cpuset_write_resmask(struct cgroup cgrp, struct cftype cft,
		* resources, wait for the previously scheduled operations before
		* proceeding, so that we don't end up keep removing tasks added
		* after execution capability is restored.
		*
		* Flushing cpuset_hotplug_work is enough to synchronize against
		* hotplug hanlding; however, cpuset_attach() may schedule
		* propagation work directly. Flush the workqueue too.
		*/
		flush_work(&cpuset_hotplug_work);
		flush_workqueue(cpuset_propagate_hotplug_wq);

		if (!cgroup_lock_live_group(cgrp))
		return -ENODEV;

Admin message