serial/pmac_zilog: Workaround problem due to interrupt on closed port (02ab8513) · Commits · 戴 / test

It seems that in qemu, we can see an interrupt in R3 despite the fact that it's masked in W1. The chip doesn't actually issue an interrupt, but we can "see" it when taking an interrupt for the other channel. This may be a qemu bug ... or not, so let's be safe and avoid calling into the UART layer when that happens which woulc cause a crash. Signed-off-by:

Benjamin Herrenschmidt <benh@kernel.crashing.org> Acked-by:

Rob Landley <rob@landley.net>

drivers/serial/pmac_zilog.c

+11 −0

Original line number	Diff line number	Diff line
		@@ -411,6 +411,17 @@ static void pmz_transmit_chars(struct uart_pmac_port *uap)
		goto ack_tx_int;
		}

		/* Under some circumstances, we see interrupts reported for
		* a closed channel. The interrupt mask in R1 is clear, but
		* R3 still signals the interrupts and we see them when taking
		* an interrupt for the other channel (this could be a qemu
		* bug but since the ESCC doc doesn't specify precsiely whether
		* R3 interrup status bits are masked by R1 interrupt enable
		* bits, better safe than sorry). --BenH.
		*/
		if (!ZS_IS_OPEN(uap))
		goto ack_tx_int;

		if (uap->port.x_char) {
		uap->flags \|= PMACZILOG_FLAG_TX_ACTIVE;
		write_zsdata(uap, uap->port.x_char);

Admin message