Commit 02a9d037 authored Nov 23, 2010 by Rabin Vincent Committed by Arnaldo Carvalho de Melo Nov 23, 2010

perf symbols: Remove incorrect open-coded container_of()

At least on ARM, padding is inserted between rb_node and sym in struct
symbol_name_rb_node, causing "((void *)sym) - sizeof(struct rb_node)" to
point inside rb_node rather than to the symbol_name_rb_node.  Fix this
by converting the code to use container_of().

Cc: Ian Munsie <imunsie@au1.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Ming Lei <tom.leiming@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <20101123163106.GA25677@debian>
Signed-off-by: Rabin Vincent <rabin@rab.in>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent c1a3a4b9

tools/perf/util/symbol.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -295,7 +295,9 @@ static void symbols__insert_by_name(struct rb_root self, struct symbol sym)
		{
		struct rb_node **p = &self->rb_node;
		struct rb_node *parent = NULL;
		struct symbol_name_rb_node symn = ((void )sym) - sizeof(parent), s;
		struct symbol_name_rb_node symn, s;

		symn = container_of(sym, struct symbol_name_rb_node, sym);

		while (*p != NULL) {
		parent = *p;

Admin message