Commit 028b186f authored by Hans de Goede's avatar Hans de Goede Committed by Hans de Goede
Browse files

efifb: Set info->fbcon_rotate_hint based on drm_get_panel_orientation_quirk 



On some hardware the LCD panel is not mounted upright in the casing,
but rotated by 90 degrees. In this case we want the console to
automatically be rotated to compensate.

The drm subsys has a quirk table for this, use the
drm_get_panel_orientation_quirk function to get the panel orientation
and set info->fbcon_rotate_hint based on this, so that the fbcon console
on top of efifb gets automatically rotated to compensate for the panel
orientation.

Acked-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171125193553.23986-7-hdegoede@redhat.com
parent 82daca29

drivers/video/fbdev/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -772,6 +772,7 @@ config FB_VESA 
config FB_EFI

	bool "EFI-based Framebuffer Support"

	depends on (FB = y) && !IA64 && EFI

	select DRM_PANEL_ORIENTATION_QUIRKS

	select FB_CFB_FILLRECT

	select FB_CFB_COPYAREA

	select FB_CFB_IMAGEBLIT

drivers/video/fbdev/efifb.c

+20 −1
Original line number Diff line number Diff line
@@ -16,6 +16,8 @@ 
#include <linux/screen_info.h>

#include <video/vga.h>

#include <asm/efi.h>

#include <drm/drm_utils.h> /* For drm_get_panel_orientation_quirk */

#include <drm/drm_connector.h>  /* For DRM_MODE_PANEL_ORIENTATION_* */



static bool request_mem_succeeded = false;

static bool nowc = false;
@@ -157,7 +159,7 @@ static u64 bar_offset; 
static int efifb_probe(struct platform_device *dev)

{

	struct fb_info *info;

	int err;

	int err, orientation;

	unsigned int size_vmode;

	unsigned int size_remap;

	unsigned int size_total;
@@ -329,6 +331,23 @@ static int efifb_probe(struct platform_device *dev) 
	info->fix = efifb_fix;

	info->flags = FBINFO_FLAG_DEFAULT | FBINFO_MISC_FIRMWARE;



	orientation = drm_get_panel_orientation_quirk(efifb_defined.xres,

						      efifb_defined.yres);

	switch (orientation) {

	default:

		info->fbcon_rotate_hint = FB_ROTATE_UR;

		break;

	case DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP:

		info->fbcon_rotate_hint = FB_ROTATE_UD;

		break;

	case DRM_MODE_PANEL_ORIENTATION_LEFT_UP:

		info->fbcon_rotate_hint = FB_ROTATE_CCW;

		break;

	case DRM_MODE_PANEL_ORIENTATION_RIGHT_UP:

		info->fbcon_rotate_hint = FB_ROTATE_CW;

		break;

	}



	err = sysfs_create_groups(&dev->dev.kobj, efifb_groups);

	if (err) {

		pr_err("efifb: cannot add sysfs attrs\n");

CRA Git | Maintained and supported by SUSTech CRA and CCSE