Commit 02782f3d authored Apr 23, 2020 by Sai Prakash Ranjan Committed by Will Deacon May 07, 2020

iommu/arm-smmu: Make remove callback message more informative



Currently on reboot/shutdown, the following messages are
displayed on the console as error messages before the
system reboots/shutdown as part of remove callback.

On SC7180:

  arm-smmu 15000000.iommu: removing device with active domains!
  arm-smmu 5040000.iommu: removing device with active domains!

Make this error message more informative and less scary.

Reported-by: Douglas Anderson <dianders@chromium.org>
Suggested-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20200423095531.9868-1-saiprakash.ranjan@codeaurora.org


[will: use dev_notice() as per Robin]
Signed-off-by: Will Deacon <will@kernel.org>

parent 1b032ec1

drivers/iommu/arm-smmu.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2244,7 +2244,7 @@ static int arm_smmu_device_remove(struct platform_device *pdev)
		return -ENODEV;

		if (!bitmap_empty(smmu->context_map, ARM_SMMU_MAX_CBS))
		dev_err(&pdev->dev, "removing device with active domains!\n");
		dev_notice(&pdev->dev, "disabling translation\n");

		arm_smmu_bus_init(NULL);
		iommu_device_unregister(&smmu->iommu);

Admin message