i915: fix error path leak in intel_sdvo_write_cmd (0274df3e) · Commits · 戴 / test

drivers/gpu/drm/i915/intel_sdvo.c

+4 −1

Original line number	Original line	Diff line number	Diff line
	@@ -444,13 +444,16 @@ static bool intel_sdvo_write_cmd(struct intel_sdvo *intel_sdvo, u8 cmd,
	struct i2c_msg *msgs;		struct i2c_msg *msgs;
	int i, ret = true;		int i, ret = true;

			/* Would be simpler to allocate both in one go ? */
	buf = (u8 )kzalloc(args_len 2 + 2, GFP_KERNEL);		buf = (u8 )kzalloc(args_len 2 + 2, GFP_KERNEL);
	if (!buf)		if (!buf)
	return false;		return false;

	msgs = kcalloc(args_len + 3, sizeof(*msgs), GFP_KERNEL);		msgs = kcalloc(args_len + 3, sizeof(*msgs), GFP_KERNEL);
	if (!msgs)		if (!msgs) {
			kfree(buf);
	return false;		return false;
			}

	intel_sdvo_debug_write(intel_sdvo, cmd, args, args_len);		intel_sdvo_debug_write(intel_sdvo, cmd, args, args_len);