Commit 0267ffce authored May 28, 2020 by Qiushi Wu Committed by Martin K. Petersen Jun 02, 2020

scsi: iscsi: Fix reference count leak in iscsi_boot_create_kobj

kobject_init_and_add() takes reference even when it fails. If this
function returns an error, kobject_put() must be called to properly
clean up the memory associated with the object.

Link: https://lore.kernel.org/r/20200528201353.14849-1-wu000273@umn.edu


Reviewed-by: Lee Duncan <lduncan@suse.com>
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 8c4e0f21

drivers/scsi/iscsi_boot_sysfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -352,7 +352,7 @@ iscsi_boot_create_kobj(struct iscsi_boot_kset *boot_kset,
		boot_kobj->kobj.kset = boot_kset->kset;
		if (kobject_init_and_add(&boot_kobj->kobj, &iscsi_boot_ktype,
		NULL, name, index)) {
		kfree(boot_kobj);
		kobject_put(&boot_kobj->kobj);
		return NULL;
		}
		boot_kobj->data = data;

Admin message