soc/tegra: fuse: Unmap registers once they are not needed anymore (02676345) · Commits · 戴 / test

Both Chip ID and strapping registers are now read out during of APB MISC initialization, the registers' mapping isn't needed anymore once registers are read. Hence let's unmap registers once they are not needed anymore, for consistency. Suggested-by:

Michał Mirosław <mirq-linux@rere.qmqm.pl> Signed-off-by:

Dmitry Osipenko <digetx@gmail.com> Signed-off-by:

Thierry Reding <treding@nvidia.com>

drivers/soc/tegra/fuse/tegra-apbmisc.c

+8 −4

Original line number	Diff line number	Diff line
		@@ -158,16 +158,20 @@ void __init tegra_init_apbmisc(void)
		}

		apbmisc_base = ioremap_nocache(apbmisc.start, resource_size(&apbmisc));
		if (!apbmisc_base)
		if (!apbmisc_base) {
		pr_err("failed to map APBMISC registers\n");
		else
		} else {
		chipid = readl_relaxed(apbmisc_base + 4);
		iounmap(apbmisc_base);
		}

		strapping_base = ioremap_nocache(straps.start, resource_size(&straps));
		if (!strapping_base)
		if (!strapping_base) {
		pr_err("failed to map strapping options registers\n");
		else
		} else {
		strapping = readl_relaxed(strapping_base);
		iounmap(strapping_base);
		}

		long_ram_code = of_property_read_bool(np, "nvidia,long-ram-code");
		}

Admin message