mtd: maps: make uclinux.c driver more explicitly non-modular (025ce02d) · Commits · 戴 / test

The Kconfig for this support is currently declared with: config MTD_UCLINUX bool "Generic uClinux RAM/ROM filesystem support" ...meaning that it currently is not being built as a module by anyone. Lets remove as much of the modular evidence that we can, so that when reading the driver there is less doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. We also replace module.h with moduleparam.h since the file does use a module_param, and leaving it as such is currently the easiest way to remain compatible with existing boot arg use cases. We also delete the MODULE_LICENSE tag etc. since all that information was (or is now) contained at the top of the file in the comments. Cc: David Woodhouse <dwmw2@infradead.org> Cc: Greg Ungerer <gerg@snapgear.com> Signed-off-by:

Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by:

Brian Norris <computersforpeace@gmail.com>

drivers/mtd/maps/uclinux.c

+4 −23

Original line number	Diff line number	Diff line
		@@ -4,11 +4,13 @@
		* uclinux.c -- generic memory mapped MTD driver for uclinux
		*
		* (C) Copyright 2002, Greg Ungerer (gerg@snapgear.com)
		*
		* License: GPL
		*/

		/****************************************************************************/

		#include <linux/module.h>
		#include <linux/moduleparam.h>
		#include <linux/types.h>
		#include <linux/init.h>
		#include <linux/kernel.h>
		@@ -117,27 +119,6 @@ static int __init uclinux_mtd_init(void)

		return(0);
		}

		/****************************************************************************/

		static void __exit uclinux_mtd_cleanup(void)
		{
		if (uclinux_ram_mtdinfo) {
		mtd_device_unregister(uclinux_ram_mtdinfo);
		map_destroy(uclinux_ram_mtdinfo);
		uclinux_ram_mtdinfo = NULL;
		}
		if (uclinux_ram_map.virt)
		uclinux_ram_map.virt = 0;
		}

		/****************************************************************************/

		module_init(uclinux_mtd_init);
		module_exit(uclinux_mtd_cleanup);

		MODULE_LICENSE("GPL");
		MODULE_AUTHOR("Greg Ungerer <gerg@snapgear.com>");
		MODULE_DESCRIPTION("Generic MTD for uClinux");
		device_initcall(uclinux_mtd_init);

		/****************************************************************************/

Admin message