Commit 02596252 authored May 20, 2019 by Gustavo A. R. Silva Committed by David S. Miller May 20, 2019

macvlan: Mark expected switch fall-through



In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/net/macvlan.c: In function ‘macvlan_do_ioctl’:
drivers/net/macvlan.c:839:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (!net_eq(dev_net(dev), &init_net))
      ^
drivers/net/macvlan.c:841:2: note: here
  case SIOCGHWTSTAMP:
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 135dd959

drivers/net/macvlan.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -838,6 +838,7 @@ static int macvlan_do_ioctl(struct net_device dev, struct ifreq ifr, int cmd)
		case SIOCSHWTSTAMP:
		if (!net_eq(dev_net(dev), &init_net))
		break;
		/* fall through */
		case SIOCGHWTSTAMP:
		if (netif_device_present(real_dev) && ops->ndo_do_ioctl)
		err = ops->ndo_do_ioctl(real_dev, &ifrr, cmd);

Admin message