Commit 0231bb53 authored Feb 01, 2013 by Jiri Olsa Committed by Ingo Molnar Feb 03, 2013

perf: Fix event group context move

When we have group with mixed events (hw/sw) we want to end up
with group leader being in hw context. So if group leader is
initialy sw event, we move all the events under hw context.

The move is done for each event by removing it from its context
and adding it back into proper one. As a part of the removal the
event is automatically disabled, which is not what we want at
this stage of creating groups.

The fix is to initialize event state after removal from sw
context.

This fix resulted from the following discussion:

  http://thread.gmane.org/gmane.linux.kernel.perf.user/1144



Reported-by: Andreas Hollmann <hollmann@in.tum.de>
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Cc: Vince Weaver <vince@deater.net>
Link: http://lkml.kernel.org/r/1359714225-4231-1-git-send-email-jolsa@redhat.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 923d8697

kernel/events/core.c

+18 −2

Original line number	Diff line number	Diff line
		@@ -907,6 +907,15 @@ list_add_event(struct perf_event event, struct perf_event_context ctx)
		ctx->nr_stat++;
		}

		/*
		* Initialize event state based on the perf_event_attr::disabled.
		*/
		static inline void perf_event__state_init(struct perf_event *event)
		{
		event->state = event->attr.disabled ? PERF_EVENT_STATE_OFF :
		PERF_EVENT_STATE_INACTIVE;
		}

		/*
		* Called at perf_event creation and when events are attached/detached from a
		* group.
		@@ -6179,8 +6188,7 @@ perf_event_alloc(struct perf_event_attr *attr, int cpu,
		event->overflow_handler = overflow_handler;
		event->overflow_handler_context = context;

		if (attr->disabled)
		event->state = PERF_EVENT_STATE_OFF;
		perf_event__state_init(event);

		pmu = NULL;

		@@ -6609,9 +6617,17 @@ SYSCALL_DEFINE5(perf_event_open,

		mutex_lock(&gctx->mutex);
		perf_remove_from_context(group_leader);

		/*
		* Removing from the context ends up with disabled
		* event. What we want here is event in the initial
		* startup state, ready to be add into new context.
		*/
		perf_event__state_init(group_leader);
		list_for_each_entry(sibling, &group_leader->sibling_list,
		group_entry) {
		perf_remove_from_context(sibling);
		perf_event__state_init(sibling);
		put_ctx(gctx);
		}
		mutex_unlock(&gctx->mutex);

Admin message