Commit 023069ba authored Jul 14, 2020 by Lee Jones Committed by Vinod Koul Jul 15, 2020

dmaengine: sun4i-dma: Demote obvious misuse of kerneldoc to standard comment blocks

No attempt has been made to document any of the demoted functions here.

Fixes the following W=1 kernel build warning(s):

drivers/dma/sun4i-dma.c:321: warning: Function parameter or member 'priv' not described in '__execute_vchan_pending'
drivers/dma/sun4i-dma.c:321: warning: Function parameter or member 'vchan' not described in '__execute_vchan_pending'
drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'chan' not described in 'generate_ndma_promise'
drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'src' not described in 'generate_ndma_promise'
drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'dest' not described in 'generate_ndma_promise'
drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'len' not described in 'generate_ndma_promise'
drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'sconfig' not described in 'generate_ndma_promise'
drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'direction' not described in 'generate_ndma_promise'
drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'chan' not described in 'generate_ddma_promise'
drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'src' not described in 'generate_ddma_promise'
drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'dest' not described in 'generate_ddma_promise'
drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'len' not described in 'generate_ddma_promise'
drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'sconfig' not described in 'generate_ddma_promise'
drivers/dma/sun4i-dma.c:577: warning: Function parameter or member 'contract' not described in 'get_next_cyclic_promise'
drivers/dma/sun4i-dma.c:596: warning: Function parameter or member 'vd' not described in 'sun4i_dma_free_contract'

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: "Emilio López" <emilio@elopez.com.ar>
Link: https://lore.kernel.org/r/20200714111546.1755231-10-lee.jones@linaro.org

Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 21e3cdb0

drivers/dma/sun4i-dma.c

+6 −6

Original line number	Diff line number	Diff line
		@@ -307,7 +307,7 @@ static void set_pchan_interrupt(struct sun4i_dma_dev *priv,
		spin_unlock_irqrestore(&priv->lock, flags);
		}

		/**
		/*
		* Execute pending operations on a vchan
		*
		* When given a vchan, this function will try to acquire a suitable
		@@ -419,7 +419,7 @@ static int sanitize_config(struct dma_slave_config *sconfig,
		return 0;
		}

		/**
		/*
		* Generate a promise, to be used in a normal DMA contract.
		*
		* A NDMA promise contains all the information required to program the
		@@ -486,7 +486,7 @@ fail:
		return NULL;
		}

		/**
		/*
		* Generate a promise, to be used in a dedicated DMA contract.
		*
		* A DDMA promise contains all the information required to program the
		@@ -543,7 +543,7 @@ fail:
		return NULL;
		}

		/**
		/*
		* Generate a contract
		*
		* Contracts function as DMA descriptors. As our hardware does not support
		@@ -565,7 +565,7 @@ static struct sun4i_dma_contract *generate_dma_contract(void)
		return contract;
		}

		/**
		/*
		* Get next promise on a cyclic transfer
		*
		* Cyclic contracts contain a series of promises which are executed on a
		@@ -589,7 +589,7 @@ get_next_cyclic_promise(struct sun4i_dma_contract *contract)
		return promise;
		}

		/**
		/*
		* Free a contract and all its associated promises
		*/
		static void sun4i_dma_free_contract(struct virt_dma_desc *vd)

Admin message