Commit 022d0547 authored May 24, 2013 by Peter Chen Committed by Felipe Balbi May 28, 2013

usb: dwc3: exynos: PHY should be deleted later than dwc3 core

If the glue layer is removed first (core layer later),
it deletes the phy device first, then the core device.
But at core's removal, it still uses PHY's resources, it may
cause kernel's oops. It is much like the problem
Paul Zimmerman reported at:
http://marc.info/?l=linux-usb&m=136547502011472&w=2

.

Besides, it is reasonable the PHY is deleted at last as
the controller is the PHY's user.

Signed-off-by: Peter Chen <peter.chen@freescale.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent f28c42c5

drivers/usb/dwc3/dwc3-exynos.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -164,9 +164,9 @@ static int dwc3_exynos_remove(struct platform_device *pdev)
		{
		struct dwc3_exynos *exynos = platform_get_drvdata(pdev);

		device_for_each_child(&pdev->dev, NULL, dwc3_exynos_remove_child);
		platform_device_unregister(exynos->usb2_phy);
		platform_device_unregister(exynos->usb3_phy);
		device_for_each_child(&pdev->dev, NULL, dwc3_exynos_remove_child);

		clk_disable_unprepare(exynos->clk);

Admin message