Commit 02198962 authored Sep 28, 2010 by Thomas Gleixner Committed by H. Peter Anvin Sep 30, 2010

x86, hpet: Fix bogus error check in hpet_assign_irq()



create_irq() returns -1 if the interrupt allocation failed, but the
code checks for irq == 0.

Use create_irq_nr() instead.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Venkatesh Pallipadi <venki@google.com>
LKML-Reference: <alpine.LFD.2.00.1009282310360.2416@localhost6.localdomain6>
Cc: stable@kernel.org
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>

parent 1cf180c9

arch/x86/kernel/hpet.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -506,7 +506,7 @@ static int hpet_assign_irq(struct hpet_dev *dev)
		{
		unsigned int irq;

		irq = create_irq();
		irq = create_irq_nr(0, -1);
		if (!irq)
		return -EINVAL;

Admin message