Commit 0209bcd4 authored Jun 29, 2011 by Amit Kumar Salecha Committed by David S. Miller Jun 30, 2011

net: add external loopback test in ethtool self test

External loopback test can be performed by application without any driver
support on normal Ethernet cards.
But on CNA devices, where multiple functions share same physical port.
Here internal loopback test and external loopback test can be initiated by
multiple functions at same time. To co exist all functions, firmware need
to regulate what test can be run by which function. So before performing external
loopback test, command need to send to firmware, which will quiescent other functions.

User may not want to run external loopback test always. As special cable need to be
connected for this test.
So adding explicit flag in ethtool self test, which will specify interface
to perform external loopback test.
ETH_TEST_FL_EXTERNAL_LB: Application set to request external loopback test
ETH_TEST_FL_EXTERNAL_LB_DONE: Driver ack if test performed

Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 781b8647

include/linux/ethtool.h

+14 −2

Original line number	Diff line number	Diff line
		@@ -310,9 +310,21 @@ struct ethtool_sset_info {
		__u32's, etc. */
		};

		/**
		* enum ethtool_test_flags - flags definition of ethtool_test
		* @ETH_TEST_FL_OFFLINE: if set perform online and offline tests, otherwise
		* only online tests.
		* @ETH_TEST_FL_FAILED: Driver set this flag if test fails.
		* @ETH_TEST_FL_EXTERNAL_LB: Application request to perform external loopback
		* test.
		* @ETH_TEST_FL_EXTERNAL_LB_DONE: Driver performed the external loopback test
		*/

		enum ethtool_test_flags {
		ETH_TEST_FL_OFFLINE = (1 << 0), /* online / offline */
		ETH_TEST_FL_FAILED = (1 << 1), /* test passed / failed */
		ETH_TEST_FL_OFFLINE = (1 << 0),
		ETH_TEST_FL_FAILED = (1 << 1),
		ETH_TEST_FL_EXTERNAL_LB = (1 << 2),
		ETH_TEST_FL_EXTERNAL_LB_DONE = (1 << 3),
		};

		/* for requesting NIC test and getting results*/

Admin message