Commit 0208bc88 authored Aug 01, 2015 by Dan Carpenter Committed by Marcel Holtmann Aug 10, 2015

Bluetooth: Fix breakage in amp_write_rem_assoc_frag()



We should be passing the pointer itself instead of the address of the
pointer.

This was a copy and paste bug when we replaced the calls to
hci_send_cmd().  Originally, the arguments were "len, cp" but we
overwrote them with "sizeof(cp), &cp" by mistake.

Fixes: b3d39140 ('Bluetooth: Move amp assoc read/write completed callback to amp.c')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

parent 2cf1b5ce

net/bluetooth/amp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -379,7 +379,7 @@ static bool amp_write_rem_assoc_frag(struct hci_dev *hdev,
		amp_ctrl_put(ctrl);

		hci_req_init(&req, hdev);
		hci_req_add(&req, HCI_OP_WRITE_REMOTE_AMP_ASSOC, sizeof(cp), &cp);
		hci_req_add(&req, HCI_OP_WRITE_REMOTE_AMP_ASSOC, len, cp);
		hci_req_run_skb(&req, write_remote_amp_assoc_complete);

		kfree(cp);

Admin message