i2c: iproc: Fix shifting 31 bits (02040811) · Commits · 戴 / test

Fix undefined behaviour in the iProc I2C driver by using 'BIT' marcro. Reported-by:

Florian Fainelli <f.fainelli@gmail.com> [wsa: in commit msg, don't say 'checkpatch' but name the issue] Signed-off-by:

drivers/i2c/busses/i2c-bcm-iproc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -720,7 +720,7 @@ static int bcm_iproc_i2c_xfer_internal(struct bcm_iproc_i2c_dev *iproc_i2c,

		/* mark the last byte */
		if (!process_call && (i == msg->len - 1))
		val \|= 1 << M_TX_WR_STATUS_SHIFT;
		val \|= BIT(M_TX_WR_STATUS_SHIFT);

		iproc_i2c_wr_reg(iproc_i2c, M_TX_OFFSET, val);
		}
		@@ -738,7 +738,7 @@ static int bcm_iproc_i2c_xfer_internal(struct bcm_iproc_i2c_dev *iproc_i2c,
		*/
		addr = i2c_8bit_addr_from_msg(msg);
		/* mark it the last byte out */
		val = addr \| (1 << M_TX_WR_STATUS_SHIFT);
		val = addr \| BIT(M_TX_WR_STATUS_SHIFT);
		iproc_i2c_wr_reg(iproc_i2c, M_TX_OFFSET, val);
		}