Commit 01ec372c authored Sep 03, 2020 by Ronnie Sahlberg Committed by Steve French Sep 06, 2020

cifs: fix DFS mount with cifsacl/modefromsid



RHBZ: 1871246

If during cifs_lookup()/get_inode_info() we encounter a DFS link
and we use the cifsacl or modefromsid mount options we must suppress
any -EREMOTE errors that triggers or else we will not be able to follow
the DFS link and automount the target.

This fixes an issue with modefromsid/cifsacl where these mountoptions
would break DFS and we would no longer be able to access the share.

Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>

parent f4d51dff

fs/cifs/inode.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1017,6 +1017,8 @@ handle_mnt_opt:
		if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MODE_FROM_SID) {
		rc = cifs_acl_to_fattr(cifs_sb, &fattr, *inode, true,
		full_path, fid);
		if (rc == -EREMOTE)
		rc = 0;
		if (rc) {
		cifs_dbg(FYI, "%s: Get mode from SID failed. rc=%d\n",
		__func__, rc);
		@@ -1025,6 +1027,8 @@ handle_mnt_opt:
		} else if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_CIFS_ACL) {
		rc = cifs_acl_to_fattr(cifs_sb, &fattr, *inode, false,
		full_path, fid);
		if (rc == -EREMOTE)
		rc = 0;
		if (rc) {
		cifs_dbg(FYI, "%s: Getting ACL failed with error: %d\n",
		__func__, rc);

Admin message