Commit 01d07820 authored Jan 04, 2009 by KOSAKI Motohiro Committed by Ingo Molnar Jan 07, 2009

sparseirq: make for_each_irq_desc() more robust



Raja reported for_each_irq_desc() has possibility unsafeness:

if anyone write folliwing code, for_each_irq_desc() doesn't work
as intended:

(right now this code does not exist at all)

 if (safe)
   for_each_irq_desc(irq, desc) {
      ...
   }
 else
   panic();

Reported-by: Raja R Harinath <harinath@hurrynot.org>
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent ede6f5ae

include/linux/irqnr.h

+6 −2

Original line number	Diff line number	Diff line
		@@ -28,13 +28,17 @@ extern struct irq_desc *irq_to_desc(unsigned int irq);
		# define for_each_irq_desc(irq, desc) \
		for (irq = 0, desc = irq_to_desc(irq); irq < nr_irqs; \
		irq++, desc = irq_to_desc(irq)) \
		if (desc)
		if (!desc) \
		; \
		else


		# define for_each_irq_desc_reverse(irq, desc) \
		for (irq = nr_irqs - 1, desc = irq_to_desc(irq); irq >= 0; \
		irq--, desc = irq_to_desc(irq)) \
		if (desc)
		if (!desc) \
		; \
		else

		#endif /* CONFIG_GENERIC_HARDIRQS */

Admin message