Commit 01cdfa91 authored Jan 14, 2019 by Mathieu Malaterre Committed by Thomas Gleixner Jan 15, 2019

genirq: Correctly annotate implicit fall through

There is a plan to build the kernel with -Wimplicit-fallthrough. The
fallthrough in __handle_irq_event_percpu() has a fallthrough annotation
which is followed by an additional comment and is not recognized by GCC.

Separate the 'fall through' and the rest of the comment with a dash so the
regular expression used by GCC matches.

Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190114203633.18557-1-malat@debian.org

parent 44133f7e

kernel/irq/handle.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -166,7 +166,7 @@ irqreturn_t __handle_irq_event_percpu(struct irq_desc desc, unsigned int flags

		__irq_wake_thread(desc, action);

		/* Fall through to add to randomness */
		/* Fall through - to add to randomness */
		case IRQ_HANDLED:
		*flags \|= action->flags;
		break;