Commit 01cb3735 authored Aug 04, 2018 by Gustavo A. R. Silva Committed by Daniel Thompson Nov 13, 2018

kdb: kdb_keyboard: mark expected switch fall-throughs



In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case, I replaced the code comments with
a proper "fall through" annotation, which is what GCC is expecting
to find.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>

parent 9eb62f0e

kernel/debug/kdb/kdb_keyboard.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -173,11 +173,11 @@ int kdb_get_kbd_char(void)
		case KT_LATIN:
		if (isprint(keychar))
		break; /* printable characters */
		/* drop through */
		/* fall through */
		case KT_SPEC:
		if (keychar == K_ENTER)
		break;
		/* drop through */
		/* fall through */
		default:
		return -1; /* ignore unprintables */
		}

Admin message