Commit 01bb31de authored Aug 12, 2019 by Larry Finger Committed by Kalle Valo Sep 03, 2019

rtlwifi: rtl8192cu: Fix value set in descriptor



In the process of converting the bit manipulation macros were converted
to use GENMASK(), the compiler reported a value too big for the field.
The offending statement was trying to write 0x100 into a 5-bit field.
An accompaning comment says to set bit 3, thus the code is changed
appropriately.

This error has been in the driver since its initial submission.

Fixes: 29d00a3e ("rtlwifi: rtl8192cu: Add routine trx")
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent b6326fc0

drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -611,7 +611,7 @@ void rtl92cu_fill_fake_txdesc(struct ieee80211_hw hw, u8 pdesc,
		SET_TX_DESC_NAV_USE_HDR(pdesc, 1);
		} else {
		SET_TX_DESC_HWSEQ_EN(pdesc, 1); /* Hw set sequence number */
		SET_TX_DESC_PKT_ID(pdesc, 0x100); /* set bit3 to 1. */
		SET_TX_DESC_PKT_ID(pdesc, BIT(3)); /* set bit3 to 1. */
		}
		SET_TX_DESC_USE_RATE(pdesc, 1); /* use data rate which is set by Sw */
		SET_TX_DESC_OWN(pdesc, 1);

Admin message