Commit 01a5f8a4 authored Jul 11, 2014 by Andrew Duggan Committed by Jiri Kosina Jul 29, 2014

HID: rmi: change logging level of log messages related to unexpected reports



Userspace tools may use hidraw to perform operations on the device from userspace while
hid-rmi is bound to the device. This can cause hid-rmi to print error messages when its
->raw_event() callback gets called as the reports pass through the HID stack. In this case
receiving responses which were not initiated by hid-rmi is not actually an error so the resulting
error messages are incorrect and misleading. This patch changes the log messages to debug so
that the messages can be turned on in the event that there is a problem and there is not
a userspace tool running.

Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 9e2c327e

drivers/hid/hid-rmi.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -377,7 +377,7 @@ static int rmi_input_event(struct hid_device hdev, u8 data, int size)
		irq_mask \|= hdata->f30.irq_mask;

		if (data[1] & ~irq_mask)
		hid_warn(hdev, "unknown intr source:%02lx %s:%d\n",
		hid_dbg(hdev, "unknown intr source:%02lx %s:%d\n",
		data[1] & ~irq_mask, __FILE__, __LINE__);

		if (hdata->f11.interrupt_base < hdata->f30.interrupt_base) {
		@@ -400,7 +400,7 @@ static int rmi_read_data_event(struct hid_device hdev, u8 data, int size)
		struct rmi_data *hdata = hid_get_drvdata(hdev);

		if (!test_bit(RMI_READ_REQUEST_PENDING, &hdata->flags)) {
		hid_err(hdev, "no read request pending\n");
		hid_dbg(hdev, "no read request pending\n");
		return 0;
		}

Admin message