Commit 01952206 authored May 27, 2020 by Yufeng Mo Committed by David S. Miller May 27, 2020

net: hns3: remove unnecessary MAC enable in app loopback



Packets will not pass through MAC during app loopback.
Therefore, it is meaningless to enable MAC while doing
app loopback. This patch removes this unnecessary action.

Signed-off-by: Yufeng Mo <moyufeng@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 60c800c6

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -6583,8 +6583,6 @@ static int hclge_set_app_loopback(struct hclge_dev *hdev, bool en)
		/* 2 Then setup the loopback flag */
		loop_en = le32_to_cpu(req->txrx_pad_fcs_loop_en);
		hnae3_set_bit(loop_en, HCLGE_MAC_APP_LP_B, en ? 1 : 0);
		hnae3_set_bit(loop_en, HCLGE_MAC_TX_EN_B, en ? 1 : 0);
		hnae3_set_bit(loop_en, HCLGE_MAC_RX_EN_B, en ? 1 : 0);

		req->txrx_pad_fcs_loop_en = cpu_to_le32(loop_en);

Admin message