Commit 01745706 authored Feb 16, 2018 by Fengguang Wu Committed by Herbert Xu Feb 22, 2018

crypto: ccree - fix memdup.cocci warnings



drivers/crypto/ccree/cc_cipher.c:629:15-22: WARNING opportunity for kmemdep

 Use kmemdup rather than duplicating its implementation

Generated by: scripts/coccinelle/api/memdup.cocci

Fixes: 63ee04c8 ("crypto: ccree - add skcipher support")
CC: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 02684839

drivers/crypto/ccree/cc_cipher.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -626,12 +626,11 @@ static int cc_cipher_process(struct skcipher_request *req,
		/* The IV we are handed may be allocted from the stack so
		* we must copy it to a DMAable buffer before use.
		*/
		req_ctx->iv = kmalloc(ivsize, flags);
		req_ctx->iv = kmemdup(iv, ivsize, flags);
		if (!req_ctx->iv) {
		rc = -ENOMEM;
		goto exit_process;
		}
		memcpy(req_ctx->iv, iv, ivsize);

		/For CTS in case of data size aligned to 16 use CBC mode/
		if (((nbytes % AES_BLOCK_SIZE) == 0) &&

Admin message