drm/amdgpu: fix ras ctrl debugfs node leak (012dd14d) · Commits · 戴 / test

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

+5 −7

Original line number	Diff line number	Diff line
		@@ -980,9 +980,9 @@ static void amdgpu_ras_debugfs_create_ctrl_node(struct amdgpu_device *adev)
		struct drm_minor *minor = adev->ddev->primary;

		con->dir = debugfs_create_dir("ras", minor->debugfs_root);
		con->ent = debugfs_create_file("ras_ctrl", S_IWUGO \| S_IRUGO, con->dir,
		debugfs_create_file("ras_ctrl", S_IWUGO \| S_IRUGO, con->dir,
		adev, &amdgpu_ras_debugfs_ctrl_ops);
		con->ent = debugfs_create_file("ras_eeprom_reset", S_IWUGO \| S_IRUGO, con->dir,
		debugfs_create_file("ras_eeprom_reset", S_IWUGO \| S_IRUGO, con->dir,
		adev, &amdgpu_ras_debugfs_eeprom_ops);
		}

		@@ -1028,10 +1028,8 @@ static void amdgpu_ras_debugfs_remove_all(struct amdgpu_device *adev)
		amdgpu_ras_debugfs_remove(adev, &obj->head);
		}

		debugfs_remove(con->ent);
		debugfs_remove(con->dir);
		debugfs_remove_recursive(con->dir);
		con->dir = NULL;
		con->ent = NULL;
		}
		/* debugfs end */

+0 −2

Original line number	Diff line number	Diff line
		@@ -317,8 +317,6 @@ struct amdgpu_ras {
		struct list_head head;
		/* debugfs */
		struct dentry *dir;
		/* debugfs ctrl */
		struct dentry *ent;
		/* sysfs */
		struct device_attribute features_attr;
		struct bin_attribute badpages_attr;