Commit 011f1754 authored Jul 28, 2019 by Colin Ian King Committed by David S. Miller Jul 29, 2019

rocker: fix memory leaks of fib_work on two error return paths



Currently there are two error return paths that leak memory allocated
to fib_work. Fix this by kfree'ing fib_work before returning.

Addresses-Coverity: ("Resource leak")
Fixes: 19a9d136 ("ipv4: Flag fib_info with a fib_nh using IPv6 gateway")
Fixes: dbcc4fa7 ("rocker: Fail attempts to use routes with nexthop objects")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 195b2919

drivers/net/ethernet/rocker/rocker_main.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -2208,10 +2208,12 @@ static int rocker_router_fib_event(struct notifier_block *nb,

		if (fen_info->fi->fib_nh_is_v6) {
		NL_SET_ERR_MSG_MOD(info->extack, "IPv6 gateway with IPv4 route is not supported");
		kfree(fib_work);
		return notifier_from_errno(-EINVAL);
		}
		if (fen_info->fi->nh) {
		NL_SET_ERR_MSG_MOD(info->extack, "IPv4 route with nexthop objects is not supported");
		kfree(fib_work);
		return notifier_from_errno(-EINVAL);
		}
		}

Admin message