Commit 011c935f authored Feb 19, 2018 by Sven Eckelmann Committed by Simon Wunderlich Feb 25, 2018

batman-adv: Ignore invalid batadv_v_gw during netlink send

The function batadv_v_gw_dump stops the processing loop when
batadv_v_gw_dump_entry returns a non-0 return code. This should only
happen when the buffer is full. Otherwise, an empty message may be
returned by batadv_gw_dump. This empty message will then stop the netlink
dumping of gateway entries. At worst, not a single entry is returned to
userspace even when plenty of possible gateways exist.

Fixes: b71bb6f9 ("batman-adv: add B.A.T.M.A.N. V bat_gw_dump implementations")
Signed-off-by: Sven Eckelmann <sven.eckelmann@openmesh.com>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>

parent 10d57028

net/batman-adv/bat_v.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -928,7 +928,7 @@ static int batadv_v_gw_dump_entry(struct sk_buff *msg, u32 portid, u32 seq,
		struct batadv_neigh_ifinfo *router_ifinfo = NULL;
		struct batadv_neigh_node *router;
		struct batadv_gw_node *curr_gw;
		int ret = -EINVAL;
		int ret = 0;
		void *hdr;

		router = batadv_orig_router_get(gw_node->orig_node, BATADV_IF_DEFAULT);

Admin message