NFS: Fix a resolution problem with nfs_inode->cache_change_attribute (011935a0) · Commits · 戴 / test

The cache_change_attribute is used to decide whether or not a directory has changed, in which case we may need to look it up again. Again, the use of 'jiffies' leads to an issue of resolution. Once again, the fix is to change nfs_inode->cache_change_attribute, and just make it a simple counter. Signed-off-by:

Trond Myklebust <Trond.Myklebust@netapp.com>

fs/nfs/dir.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -661,7 +661,7 @@ static int nfs_fsync_dir(struct file filp, struct dentry dentry, int datasync)
		*/
		void nfs_force_lookup_revalidate(struct inode *dir)
		{
		NFS_I(dir)->cache_change_attribute = jiffies;
		NFS_I(dir)->cache_change_attribute++;
		}

		/*

fs/nfs/inode.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -306,7 +306,6 @@ nfs_fhget(struct super_block sb, struct nfs_fh fh, struct nfs_fattr *fattr)

		nfsi->read_cache_jiffies = fattr->time_start;
		nfsi->attr_gencount = fattr->gencount;
		nfsi->cache_change_attribute = now;
		inode->i_atime = fattr->atime;
		inode->i_mtime = fattr->mtime;
		inode->i_ctime = fattr->ctime;

Admin message