Commit 0116651c authored Oct 26, 2010 by Namhyung Kim Committed by Linus Torvalds Oct 26, 2010

mm: remove temporary variable on generic_file_direct_write()



'end' shadows earlier one and is not necessary at all.  Remove it and use
'pos' instead.  This removes following sparse warnings:

 mm/filemap.c:2180:24: warning: symbol 'end' shadows an earlier one
 mm/filemap.c:2132:25: originally declared here

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 68da336a

mm/filemap.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -2193,12 +2193,12 @@ generic_file_direct_write(struct kiocb iocb, const struct iovec iov,
		}

		if (written > 0) {
		loff_t end = pos + written;
		if (end > i_size_read(inode) && !S_ISBLK(inode->i_mode)) {
		i_size_write(inode, end);
		pos += written;
		if (pos > i_size_read(inode) && !S_ISBLK(inode->i_mode)) {
		i_size_write(inode, pos);
		mark_inode_dirty(inode);
		}
		*ppos = end;
		*ppos = pos;
		}
		out:
		return written;

Admin message