Commit 0109c2c4 authored by mark gross's avatar mark gross Committed by Rafael J. Wysocki
Browse files

PM QoS: Correct pr_debug() misuse and improve parameter checks 



Correct some pr_debug() misuse and add a stronger parameter check to
pm_qos_write() for the ASCII hex value case.  Thanks to Dan Carpenter
for pointing out the problem!

Signed-off-by: default avatarmark gross <markgross@thegnar.org>
Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
parent 152e1d59

kernel/pm_qos_params.c

+3 −1
Original line number Diff line number Diff line
@@ -389,10 +389,12 @@ static ssize_t pm_qos_power_write(struct file *filp, const char __user *buf, 
	} else if (count == 11) { /* len('0x12345678/0') */

		if (copy_from_user(ascii_value, buf, 11))

			return -EFAULT;

		if (strlen(ascii_value) != 10)

			return -EINVAL;

		x = sscanf(ascii_value, "%x", &value);

		if (x != 1)

			return -EINVAL;

		pr_debug(KERN_ERR "%s, %d, 0x%x\n", ascii_value, x, value);

		pr_debug("%s, %d, 0x%x\n", ascii_value, x, value);

	} else

		return -EINVAL;

CRA Git | Maintained and supported by SUSTech CRA and CCSE