Commit 00ece7e4 authored Nov 25, 2011 by Tarun Kanti DebBarma

gpio/omap: fix trigger type to unsigned



The GPIO trigger parameter is of type unsigned.
enum {
        IRQ_TYPE_NONE           = 0x00000000,
        IRQ_TYPE_EDGE_RISING    = 0x00000001,
        IRQ_TYPE_EDGE_FALLING   = 0x00000002,
        IRQ_TYPE_EDGE_BOTH      = (IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING),
        IRQ_TYPE_LEVEL_HIGH     = 0x00000004,
        IRQ_TYPE_LEVEL_LOW      = 0x00000008,
        IRQ_TYPE_LEVEL_MASK     = (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH),
        IRQ_TYPE_SENSE_MASK     = 0x0000000f,

        IRQ_TYPE_PROBE          = 0x00000010,
...
};
Even though gpio_irq_type(struct irq_data *d, unsigned type) has the right type
of parameter, the subsequent called functions set_gpio_triggering() and
set_gpio_trigger() wrongly makes it signed integer. Fix this.

Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Reviewed-by: Kevin Hilman <khilman@ti.com>
Signed-off-by: Kevin Hilman <khilman@ti.com>

parent 381a752f

drivers/gpio/gpio-omap.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -245,7 +245,7 @@ static void _set_gpio_debounce(struct gpio_bank *bank, unsigned gpio,
		}

		static inline void set_gpio_trigger(struct gpio_bank *bank, int gpio,
		int trigger)
		unsigned trigger)
		{
		void __iomem *base = bank->base;
		u32 gpio_bit = 1 << gpio;
		@@ -327,7 +327,8 @@ static void _toggle_gpio_edge_triggering(struct gpio_bank *bank, int gpio)
		static void _toggle_gpio_edge_triggering(struct gpio_bank *bank, int gpio) {}
		#endif

		static int _set_gpio_triggering(struct gpio_bank *bank, int gpio, int trigger)
		static int _set_gpio_triggering(struct gpio_bank *bank, int gpio,
		unsigned trigger)
		{
		void __iomem *reg = bank->base;
		void __iomem *base = bank->base;

Admin message