Input: at32psif - drop unnecessary error messages and other changes (009af5fd) · Commits · 戴 / test

Error messages after memory allocation failures are unnecessary and can be dropped, given that they are emitted as dev_dbg() so nobody except person actively debugging the driver would see them. Also replace jump to return 'goto l; ... l: return e;' with 'return e;' Signed-off-by:

Guenter Roeck <linux@roeck-us.net> Signed-off-by:

Dmitry Torokhov <dmitry.torokhov@gmail.com>

drivers/input/serio/at32psif.c

+3 −9

Original line number	Diff line number	Diff line
		@@ -159,13 +159,12 @@ static int psif_open(struct serio *io)

		retval = clk_enable(psif->pclk);
		if (retval)
		goto out;
		return retval;

		psif_writel(psif, CR, PSIF_BIT(CR_TXEN) \| PSIF_BIT(CR_RXEN));
		psif_writel(psif, IER, PSIF_BIT(RXRDY));

		psif->open = true;
		out:
		return retval;
		}

		@@ -210,16 +209,12 @@ static int __init psif_probe(struct platform_device *pdev)
		int ret;

		psif = kzalloc(sizeof(struct psif), GFP_KERNEL);
		if (!psif) {
		dev_dbg(&pdev->dev, "out of memory\n");
		ret = -ENOMEM;
		goto out;
		}
		if (!psif)
		return -ENOMEM;
		psif->pdev = pdev;

		io = kzalloc(sizeof(struct serio), GFP_KERNEL);
		if (!io) {
		dev_dbg(&pdev->dev, "out of memory\n");
		ret = -ENOMEM;
		goto out_free_psif;
		}
		@@ -297,7 +292,6 @@ out_free_io:
		kfree(io);
		out_free_psif:
		kfree(psif);
		out:
		return ret;
		}

Admin message